[Libssh] Windows patch

[Aris Adamantiadis]

Hello,
Keisial a écrit :
> Waiting moderation there is a copy of this message, as well as the patch 
> which should makes libssh work on any 32-bit windows with getaddrinfo.
> 
I let it go through, I think everybody has received it.
Thanks for your patch. I added it into the bugtracker.
> Windows specific:
> There's a Makefile.Windows and a predefined config.h.win32-openssl
> If you want to use libgcrypt or have the libraries on different folders, 
> you'll need to manually edit them.
> 
That's not very clean :( but if that works, it's better than nothing

> sample.c wasn't ported due to termios.h not being available in Windows
> A dummy gai_strerror.c was copied from glibc because windows misses that 
> function.
I'd prefer finding an alternative to this. I'll take a look
> 
> General code:
> *Fixed the SIGSEGV when an unavailable cipher was requested (the return 
> of ssh_find_matching wasn't checked).
good
> *All calls to read & write have been changed into recv & send. As the 
> existence of data is previously checked, the 0 parameter shouldn't 
> change anything, but may be worth playing with it.
I know there are some semantic changes when changing from write/read to 
recv/send.
I'm writing a new socket wrapper that will make this easier next time.
> *The sockets are now closed with closesocket, #defined to close on 
> non-windows.
With the wrapper coded, there won't be any need for a macro anymore. 
it's best.
> *I removed aes256-cbc,aes192-cbc,3des-cbc from the negotiated ciphers 
> (not its code). Since they didn't work anyway, the other end will 
> hopefully support a cipher we speak.
It has been fixed this afternoon. A very silly bug.
> *A session->fd>0 fixed to >=
It will disapear with the code i'm writing now.
Thanks for your patch again.
> 
Aris